20 Feb
2019
20 Feb
'19
1:44 a.m.
Chris Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31476 )
Change subject: mb/google/sarien/variants/sarien: Adjust TP/TS I2C CLK to meet spec ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31476/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31476/2//COMMIT_MSG@8 PS2, Line 8:
What does the spec require? Below 400 KHz?
TP 380 KHz ~ 410 KHz TS below 400 KHz
https://review.coreboot.org/#/c/31476/2//COMMIT_MSG@10 PS2, Line 10:
One space.
Done
https://review.coreboot.org/#/c/31476/2//COMMIT_MSG@10 PS2, Line 10: KHZ
KHz
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/31476
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53b60354e5a7a0ace8efb677775c0a9f8779061d
Gerrit-Change-Number: 31476
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Zhou chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-CC: John Su john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 01:44:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment