Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40000 )
Change subject: soc/amd/common/psp: Move early init to soc
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40000/1/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/psp.h:
https://review.coreboot.org/c/coreboot/+/40000/1/src/soc/amd/common/block/in...
PS1, Line 18: /* Get the mailbox base address - specific to family of device. */
Does this mean it must be defined by each SoC that makes use of this code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice3d06d6437f59a529c26fc2359565c940d39482
Gerrit-Change-Number: 40000
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 01 Apr 2020 13:07:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment