[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to...

[V Sowmya (Code Review)]

V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )

Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common
......................................................................

Patch Set 18:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... 
File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... 
PS18, Line 569:  * Sends GLOBAL_RESET_REQ cmd to CSE.The reset can be GLOBAL_RESET/
reset type

https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... 
File src/soc/intel/common/block/include/intelblocks/cse.h:

https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block... 
PS18, Line 114: u8
> Done

This needs to be aligned with the declaration here -> https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block...