Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42609 )
Change subject: Makefile.inc: Add CARRIER_DIR to component discovery
......................................................................
Patch Set 18:
Patch Set 17:
Patch Set 10:
What's the relationship between carrier boards and modules: can a carrier
board be used for modules that differ more than what we could model in
variants?
In the case of the Kontron module, variant refers to the COMe-mAL10 or COMe-m4AL10
module type. They differ in the type of memory (DDR3L or DDR4), and maybe they
differ in some chips.
[…]
Can you add part of this explanation/answer, I just left the first paragraph, to the commit message? That’d be great as documentation.
I have added more details about my idea to the commit message, please review.
Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42609
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6b2f8994b1293ae6f5bda8c9cc95128ba0abf7a
Gerrit-Change-Number: 42609
Gerrit-PatchSet: 18
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 15 Nov 2020 13:07:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment