Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47059 )
Change subject: libpayload/x86: Add enumeration of Intel family 6 models
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47059/1/payloads/libpayload/include...
File payloads/libpayload/include/x86/arch/cpuid.h:
https://review.coreboot.org/c/coreboot/+/47059/1/payloads/libpayload/include...
PS1, Line 74: HASWELL_GT3E = 0x46,
I know. […]
I guess? You can take a look by yourself: https://www.extremetech.com/wp-content/uploads/2014/09/broadwell-haswell-chi...
It's not critical, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47059
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf8ddaf510eb513ee74af3e78da46b04802a91b9
Gerrit-Change-Number: 47059
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 31 Oct 2020 23:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment