HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40835 )
Change subject: nb/intel: Fix 16-bit read/write PCI_COMMAND register
......................................................................
Patch Set 6:
(1 comment)
Thank you.
https://review.coreboot.org/c/coreboot/+/40835/6/src/northbridge/intel/gm45/...
File src/northbridge/intel/gm45/iommu.c:
https://review.coreboot.org/c/coreboot/+/40835/6/src/northbridge/intel/gm45/...
PS6, Line 47: u16 cmd = pci_read_config8(igd, PCI_COMMAND);
: cmd &= ~(PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY);
: pci_write_config16(igd, PCI_COMMAND, cmd);
Can be written as […]
maybe for the next changes
(see https://review.coreboot.org/c/coreboot/+/41631 )
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40835
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c7fb10308a6fcd1ead292c53ed03ddc693f6f15
Gerrit-Change-Number: 40835
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 May 2020 17:25:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment