Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34752/9/src/arch/x86/exit_car.S File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/34752/9/src/arch/x86/exit_car.S@44 PS9, Line 44: executing be executing
https://review.coreboot.org/c/coreboot/+/34752/9/src/arch/x86/exit_car.S@146 PS9, Line 146: call ramstage_start I think this should just be a jmp. Once you perform this call the stack is no longer aligned to 16 bytes. C functions expect the calls to be done with 16-byte alignment, but we're just traversing through more assembly. Thoughts?