Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34678 )
Change subject: common/block/imc: Add Integrated Memory Controller (IMC) driver ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/... File src/soc/intel/common/block/imc/imc.c:
https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/... PS4, Line 96: int any reason to use int vs bool if only returning 0 and -1?
https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/... PS4, Line 106: return -1; do we want to fail silently here?
https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/... PS4, Line 147: goto cleanup; another silent fail