Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43410 )
Change subject: mb/51nb/x210/gpio: Convert configuration to macros
......................................................................
Patch Set 5:
(1 comment)
Patch Set 3:
thinking out loud: would it make more sense to drop the invalid config bits from the raw values first, then convert the "corrected" raw values to macros cleanly?
Ok, I'll do it later.
https://review.coreboot.org/c/coreboot/+/43410/5/src/mainboard/51nb/x210/gpi...
File src/mainboard/51nb/x210/gpio.h:
https://review.coreboot.org/c/coreboot/+/43410/5/src/mainboard/51nb/x210/gpi...
PS5, Line 131: PAD_CFG_GPIO_BIDIRECT
What do you think about this? CB:42914
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18c0c321561eee04ff927681b0a231f6d79c63e2
Gerrit-Change-Number: 43410
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 Jul 2020 15:00:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment