Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42944 )
Change subject: soc/amd/common: Use ACPIMMIO_BASE() in ASL
......................................................................
Patch Set 2: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/42944/2/src/mainboard/google/kahlee...
File src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/audio.asl:
https://review.coreboot.org/c/coreboot/+/42944/2/src/mainboard/google/kahlee...
PS2, Line 21: Method (_CRS, 0x0, Serialized) {
: Name (RBUF, ResourceTemplate () {
: // Memory resource is for MISC FCH register set.
: // It is needed for enabling the clock.
: Memory32Fixed(ReadWrite, ACPIMMIO_BASE(MISC), 0x100)
: })
:
: Return (RBUF)
: }
The reason to do this in this change is because IASL does not like additions on Memory32Fixed values […]
Ah, I couldn't access the error.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42944
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff6bdbe5a12f1a47c7ce348a628e0b67aac37c7c
Gerrit-Change-Number: 42944
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Jan 2021 20:16:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment