Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39941 )
Change subject: soc/intel/broadwell: add ACPI backlight support ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39941/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39941/1//COMMIT_MSG@11 PS1, Line 11: to match prototypes in i915.h and avoid conflicts.
will look into that and rebase if appropriate
looks like ironlake, sandybridge, and haswell all implement gtt_{read,write,poll} in their gma.c, so adjusting Broadwell's signatures seems like the cleanest solution ATM
https://review.coreboot.org/c/coreboot/+/39941/1/src/soc/intel/broadwell/igd... File src/soc/intel/broadwell/igd.c:
https://review.coreboot.org/c/coreboot/+/39941/1/src/soc/intel/broadwell/igd... PS1, Line 640: }
had modeled after Haswell implementation, but you're right, we don't. […]
Done
https://review.coreboot.org/c/coreboot/+/39941/1/src/soc/intel/broadwell/igd... PS1, Line 642: device
had modeled after Haswell implementation vs Skylake. […]
Done