Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39674 )
Change subject: mb/google/deltaur: Add initial GPIO configuration ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39674/6/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39674/6/src/mainboard/google/deltau... PS6, Line 57: PAD_CFG_GPI This GPIO is configured in early table - same config. So do we need to configure it again?
https://review.coreboot.org/c/coreboot/+/39674/6/src/mainboard/google/deltau... PS6, Line 151: PAD_CFG_GPI(GPP_C22, NONE, PLTRST), : /* C23 : GPP_C23 ==> H1_PCH_INT# */ : PAD_CFG_GPI_APIC(GPP_C23, NONE, PLTRST, EDGE_SINGLE, INVERT), Configured in early table.
https://review.coreboot.org/c/coreboot/+/39674/6/src/mainboard/google/deltau... PS6, Line 203: PAD_CFG_GPI(GPP_E3, NONE, PLTRST), Configured in Early table.
https://review.coreboot.org/c/coreboot/+/39674/6/src/mainboard/google/deltau... PS6, Line 271: GPP_F11 Nit: GPP_F15
https://review.coreboot.org/c/coreboot/+/39674/6/src/mainboard/google/deltau... PS6, Line 425: GPP_F11 Nit: GPP_F15