Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36431 )
Change subject: soc/intel/icelake: Remove redundant dependency check in cpu.c
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb...
File src/soc/intel/icelake/bootblock/cpu.c:
https://review.coreboot.org/c/coreboot/+/36431/2/src/soc/intel/icelake/bootb...
PS2, Line 23: if (CONFIG(BOOT_DEVICE_MEMORY_MAPPED))
If you are going to make that assumption then why have the BOOT_DEVICE_MEMORY_MAPPED check as well? […]
yes, i was thinking that, shouldn't we make that call implicit of any check as we know its SPI memory mapped for sure ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36431
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46d9ec054c4804ca756f2101085a55e91b5cc6f0
Gerrit-Change-Number: 36431
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 15:36:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment