Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 34:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30987/31/Documentation/mainboard/as... File Documentation/mainboard/asus/a88xm-e.md:
https://review.coreboot.org/c/coreboot/+/30987/31/Documentation/mainboard/as... PS31, Line 98: Kaveri
yes, it is.
Ack
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... PS31, Line 93: config CONFIG_DRIVERS_PS2_KEYBOARD : bool : default y
the board has dedicated PS2 ports for keyboard and mouse
Even then, SeaBIOS has drivers to initialize the keyboard, so I would not set this here.
https://review.coreboot.org/c/coreboot/+/30987/31/src/mainboard/asus/a88xm-e... PS31, Line 105: config POST_IO : bool : default n : : config CONFIG_POST_DEVICE_PCI_PCIE : bool : default y
I have an external PCI debugger which was used
Right. As it does not come with the mainboard, I would not set these by default. If you want to select these, you can use `site-local` to have your own Kconfig overrides