Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35035 )
Change subject: arch/x86: Implement RESET_VECTOR_IN_RAM ......................................................................
Patch Set 17:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35035/17//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35035/17//COMMIT_MSG@20 PS17, Line 20: Remove the postcar stage. Disable? It's not really removed, just not built and added.
https://review.coreboot.org/c/coreboot/+/35035/17/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35035/17/Makefile.inc@1175 PS17, Line 1175: ifneq `ifneq (...,y)` is hard to read, the y sticks out. How about `ifeq` and switching the cases?
https://review.coreboot.org/c/coreboot/+/35035/17/src/arch/x86/early_ram.ld File src/arch/x86/early_ram.ld:
https://review.coreboot.org/c/coreboot/+/35035/17/src/arch/x86/early_ram.ld@... PS17, Line 6: /* Encouraged comment style wants a line break after the /*
https://review.coreboot.org/c/coreboot/+/35035/17/src/arch/x86/early_ram.ld@... PS17, Line 18: _PAD_FOR_ALIGNS = 0x20; Please add a comment what exactly this accounts for.
https://review.coreboot.org/c/coreboot/+/35035/17/src/arch/x86/memlayout.ld File src/arch/x86/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/35035/17/src/arch/x86/memlayout.ld@... PS17, Line 57: #include <arch/x86/id.ld> How does it get into the coreboot.rom then?