5 comments:
Patch Set #17, Line 20: Remove the postcar stage.
Disable? It's not really removed, just not built and added.
Patch Set #17, Line 1175: ifneq
`ifneq (...,y)` is hard to read, the y sticks out. How about `ifeq` and
switching the cases?
File src/arch/x86/early_ram.ld:
Encouraged comment style wants a line break after the /*
Patch Set #17, Line 18: _PAD_FOR_ALIGNS = 0x20;
Please add a comment what exactly this accounts for.
File src/arch/x86/memlayout.ld:
Patch Set #17, Line 57: #include <arch/x86/id.ld>
How does it get into the coreboot.rom then?
To view, visit change 35035. To unsubscribe, or for help writing mail filters, visit settings.