Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39942 )
Change subject: soc/intel/baytrail: add ACPI backlight support ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39942/2/src/soc/intel/baytrail/gfx.... File src/soc/intel/baytrail/gfx.c:
https://review.coreboot.org/c/coreboot/+/39942/2/src/soc/intel/baytrail/gfx.... PS2, Line 400: device Everyone else seems to use "dev"
https://review.coreboot.org/c/coreboot/+/39942/2/src/soc/intel/baytrail/gfx.... PS2, Line 402: const struct soc_intel_baytrail_config *chip = device->chip_info; Will this ever dereference a null pointer?