build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32546 )
Change subject: qcom: Add i2c driver ......................................................................
Patch Set 1:
(64 comments)
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c File src/soc/qualcomm/qcs405/blsp.c:
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c@49 PS1, Line 49: case BLSP_QUP_ID_1: code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c@49 PS1, Line 49: case BLSP_QUP_ID_1: please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c@54 PS1, Line 54: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c@54 PS1, Line 54: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c@55 PS1, Line 55: default: code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c@56 PS1, Line 56: return 1; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c@56 PS1, Line 56: return 1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c@57 PS1, Line 57: } code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/blsp.c@57 PS1, Line 57: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/i2c.c File src/soc/qualcomm/qcs405/i2c.c:
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/i2c.c@87 PS1, Line 87: if (QUP_SUCCESS != qup_ret) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/i2c.c@106 PS1, Line 106: if (QUP_SUCCESS != qup_ret) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/i2c.c@157 PS1, Line 157: int platform_i2c_transfer(unsigned bus, struct i2c_msg *segments, Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c File src/soc/qualcomm/qcs405/qup.c:
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@59 PS1, Line 59: u32 clk_freq_out; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@59 PS1, Line 59: u32 clk_freq_out; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@60 PS1, Line 60: u8 fs_div; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@60 PS1, Line 60: u8 fs_div; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@61 PS1, Line 61: u8 ht_div; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@61 PS1, Line 61: u8 ht_div; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@65 PS1, Line 65: {100000, 124, 62}, code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@65 PS1, Line 65: {100000, 124, 62}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@66 PS1, Line 66: {400000, 28, 14}, code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@66 PS1, Line 66: {400000, 28, 14}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@67 PS1, Line 67: {1000000, 8, 5}, code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@67 PS1, Line 67: {1000000, 8, 5}, please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@70 PS1, Line 70: static void i2c_set_mstr_clk_ctl(unsigned id, unsigned hz) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@70 PS1, Line 70: static void i2c_set_mstr_clk_ctl(unsigned id, unsigned hz) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@72 PS1, Line 72: int i; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@72 PS1, Line 72: int i; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@73 PS1, Line 73: struct i2c_clk_div_fld *itr = i2c_clk_div_map; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@73 PS1, Line 73: struct i2c_clk_div_fld *itr = i2c_clk_div_map; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@74 PS1, Line 74: u8 fs_div = 0; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@74 PS1, Line 74: u8 fs_div = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@75 PS1, Line 75: u8 ht_div = 0; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@75 PS1, Line 75: u8 ht_div = 0; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@76 PS1, Line 76: u32 mstr_clk_ctl; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@76 PS1, Line 76: u32 mstr_clk_ctl; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@78 PS1, Line 78: for (i = 0; i < ARRAY_SIZE(i2c_clk_div_map); ++i, ++itr) { code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@78 PS1, Line 78: for (i = 0; i < ARRAY_SIZE(i2c_clk_div_map); ++i, ++itr) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@79 PS1, Line 79: if (hz == itr->clk_freq_out) { code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@79 PS1, Line 79: if (hz == itr->clk_freq_out) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@80 PS1, Line 80: if (!fs_div) code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@80 PS1, Line 80: if (!fs_div) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@81 PS1, Line 81: fs_div = itr->fs_div; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@81 PS1, Line 81: fs_div = itr->fs_div; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@82 PS1, Line 82: if (!ht_div) code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@82 PS1, Line 82: if (!ht_div) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@83 PS1, Line 83: ht_div = itr->ht_div; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@83 PS1, Line 83: ht_div = itr->ht_div; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@84 PS1, Line 84: break; code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@84 PS1, Line 84: break; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@85 PS1, Line 85: } code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@85 PS1, Line 85: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@86 PS1, Line 86: } code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@86 PS1, Line 86: } please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@88 PS1, Line 88: /* format values in clk-ctl cache */ code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@89 PS1, Line 89: mstr_clk_ctl = ((ht_div & 0xff) << 16) |(fs_div & 0xff); code indent should use tabs where possible
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@89 PS1, Line 89: mstr_clk_ctl = ((ht_div & 0xff) << 16) |(fs_div & 0xff); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@89 PS1, Line 89: mstr_clk_ctl = ((ht_div & 0xff) << 16) |(fs_div & 0xff); need consistent spacing around '|' (ctx:WxV)
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@141 PS1, Line 141: static qup_return_t qup_wait_for_state(blsp_qup_id_t id, unsigned wait_for) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@236 PS1, Line 236: unsigned data_len = p_tx_obj->p.iic.data_len; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@237 PS1, Line 237: unsigned idx = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@353 PS1, Line 353: unsigned data_len = p_tx_obj->p.iic.data_len; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@354 PS1, Line 354: unsigned idx = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32546/1/src/soc/qualcomm/qcs405/qup.c@513 PS1, Line 513: unsigned curr_state = read32(QUP_ADDR(id, QUP_STATE)); Prefer 'unsigned int' to bare use of 'unsigned'