Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39317 )
Change subject: soc/intel/tigerlake: Enable CNVi Mode
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39317/3/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39317/3/src/soc/intel/tigerlake/fsp...
PS3, Line 153: params->CnviMode = config->CnviMode;
: params->CnviBtCore = config->CnviBtCore;
a) Yes, it should be possible to check that. You should be able to use pcidev_path_on_root(). […]
CnviMode = 1 means Auto detection, if its 0 means its disabled, Hence we need this to be in Auto detection mode. Also Cnvi init is doing couple of other things apart from basic gpio config when its in Auto Mode.
1. Configure sideband communication channel for WiFi
2. Configure BT
3. Configure CNVi interrupt
Details are in ClientOneSiliconPkg/IpBlock/Cnvi/LibraryPrivate/PeiCnviLib/PeiCnviLib.c
I will update the Cnvi enable as discussed in a).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic372348a1409b2594a85b71b2fc742be96b84b87
Gerrit-Change-Number: 39317
Gerrit-PatchSet: 3
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Mar 2020 23:34:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-MessageType: comment