Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure
......................................................................
Patch Set 2:
Patch Set 2:
I get why you want this but in my opinion it violates the naming convention and makes the tree less readable/logical.
Patch Set 2:
I first need to check socket or sb and then I can find it in the tree?
What about `find src/mainboard | grep sch-f`?
Well, the problem here is that supermicro has a bad naming scheme. I am open to discussion and IMHO it's very important to have conventions and stick to them but in this case supermicro's bad naming scheme requires some unconventional tree. We really should not waste our time discussing this _too_ much :-) Isn't it more important to get more boards supported than any naming scheme? ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29
Gerrit-Change-Number: 35426
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 16 Sep 2019 16:29:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment