Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37471 )
Change subject: vboot: Clear secdata change flags after factory init ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37471/2/src/security/vboot/secdata_... File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/37471/2/src/security/vboot/secdata_... PS2, Line 191: return write_secdata(index, data, length);
Could you please explain this part of the change?
Sorry, just drive-by fixing minor things as I see them. Added to commit message.
https://review.coreboot.org/c/coreboot/+/37471/2/src/security/vboot/secdata_... PS2, Line 402: VB2_CONTEXT_SECDATA_KERNEL_CHANGED);
Please add comment here why this is needed.
Done