Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41045 )
Change subject: tests: Add <tests/test.h> wrapper header and fix --gc-sections ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41045/1/tests/Makefile.inc File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41045/1/tests/Makefile.inc@17 PS1, Line 17: -include $(src)/include/rules.h -include $(testsrc)/include/test.h
While I really like your optimization, with putting all necessary headers into test. […]
Fair enough, I'm fine including it explicitly too. Maybe let me introduce an include/tests subdirectory so that we can have test headers without risking naming clashes to anything else.
https://review.coreboot.org/c/coreboot/+/41045/1/tests/Makefile.inc@41 PS1, Line 41: subdirs:= tests/arch tests/commonlib tests/console tests/cpu tests/device
Let's use newly-introduced $(testsrc) here.
$(testsrc) is absolute but in all other cases subdirs are defined relative, so I would keep it that way here too (even though I think it would also work absolute).