Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31235 )
Change subject: soc/intel: Fix for missing mem_rank info in SMBIOS
......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/#/c/31235/9/3rdparty/blobs
File 3rdparty/blobs:
PS9:
This should be removed.
https://review.coreboot.org/#/c/31235/9/src/soc/intel/common/smbios.h
File src/soc/intel/common/smbios.h:
https://review.coreboot.org/#/c/31235/9/src/soc/intel/common/smbios.h@24
PS9, Line 24: dim
dimm?
https://review.coreboot.org/#/c/31235/9/src/soc/intel/common/smbios.c
File src/soc/intel/common/smbios.c:
https://review.coreboot.org/#/c/31235/9/src/soc/intel/common/smbios.c@23
PS9, Line 23: rankInDimm
keep this the same as the param name in declaration in smbios.h?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I212215040e4786c258a9c604cc5c2bb62867c842
Gerrit-Change-Number: 31235
Gerrit-PatchSet: 9
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 11 Feb 2019 19:56:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment