Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32090 )
Change subject: smbios: Add and adapt fields for 32 bits SMBIOS to version 3.2 ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/#/c/32090/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32090/11//COMMIT_MSG@7 PS11, Line 7: 32 bits What is "32 bits SMBIOS"?
https://review.coreboot.org/#/c/32090/11//COMMIT_MSG@10 PS11, Line 10: Future work will upgrade the smbios_entry to the 64 bits format Please provide the reason for this change.
https://review.coreboot.org/#/c/32090/11/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32090/11/src/arch/x86/smbios.c@280 PS11, Line 280: t->speed = 2 * dimm->ddr_frequency; Did somebody check *all* callers that they report the *clock* frequency?
https://review.coreboot.org/#/c/32090/11/src/arch/x86/smbios.c@804 PS11, Line 804: se->minor_version = 2; Beside increasing the version, this change seems to only add optional fields. Did anybody check if there are any mandatory changes before increasing the version?