Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42193 )
Change subject: soc/mediatek/mt8183: Fix some programming errors of DRAMC setting
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42193/4/src/soc/mediatek/mt8183/dra...
File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/42193/4/src/soc/mediatek/mt8183/dra...
PS4, Line 894:
Ooops, I didn't notice the register was changed. For indentation, I'd still suggest writing […]
Sounds good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42193
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35e25c922ed45216d5f04835abcd10809a8d559a
Gerrit-Change-Number: 42193
Gerrit-PatchSet: 4
Gerrit-Owner: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Jul 2020 13:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment