Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39863 )
Change subject: mb/google/glados: set sane Kconfig defaults
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39863/1/src/mainboard/google/glados...
File src/mainboard/google/glados/Kconfig:
https://review.coreboot.org/c/coreboot/+/39863/1/src/mainboard/google/glados...
PS1, Line 98: config CONSOLE_SERIAL
: bool
: default n
oops, missed this one. My earlier comments just refer to the FSP stuff.
How is the port non-existant? Why is there a UART_FOR_CONSOLE above if
there is no port?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39863
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifad6f805e66438e2c436d9fa235d9be2ecf69179
Gerrit-Change-Number: 39863
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 27 Mar 2020 20:17:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment