Attention is currently required from: Tristan Corrick, Arthur Heymans, Iru Cai (vimacs).
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform
......................................................................
Patch Set 23: Code-Review+1
(4 comments)
File util/autoport/haswell.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/f69d62eb_c1f25a30
PS23, Line 18: */
nit: comment end should have a space before
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/08f3c690_09f4e16a
PS23, Line 249: /* Shared with ME. Flashrom is unable to handle it. */
Untrue
https://review.coreboot.org/c/coreboot/+/30890/comment/18ff2078_c3fc9794
PS23, Line 393: void mainboard_config_superio(void)
It's optional
https://review.coreboot.org/c/coreboot/+/30890/comment/ee11df2a_7a6d36dc
PS23, Line 604: gnvs->tpsv = 90;
Most often, this is dead code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f6e8c97b5122101de2f36bba8ba9f8ddd5b813a
Gerrit-Change-Number: 30890
Gerrit-PatchSet: 23
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Pablo Stebler
pablo@stebler.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska
github@slrie.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 09:27:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment