Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32298 )
Change subject: mb/google/octopus: Add keyboard backlight support for Droid/Blorb
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32298/1/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/bobba/include/variant/ec.h:
https://review.coreboot.org/#/c/32298/1/src/mainboard/google/octopus/variant...
PS1, Line 22: #define EC_ENABLE_KEYBOARD_BACKLIGHT
It looks like the ASL asks the EC if there's a backlight, so this looks fine by me:
https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32298
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74684e3905d34b61fa4b851798dbca018f986e5a
Gerrit-Change-Number: 32298
Gerrit-PatchSet: 1
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Apr 2019 15:14:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment