Attention is currently required from: Bora Guvendik, Furquan Shaikh, Selma Bensaid, Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Angel Pons, Patrick Rudolph. Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50996 )
Change subject: mb/adlrvp: Fix DDR5 Boot issue ......................................................................
Patch Set 18:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50996/comment/9274f720_1fed138a PS14, Line 9: The coreboot SMBus driver requires additional changes
please use col 72 ?
Done
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/50996/comment/3b857bcc_43394a58 PS14, Line 55: memcfg_init(m_cfg, mem_config, &ddr4_ddr5_spd_info, half_populated); : break;
isn't this is same as line 59-60 below ?
Ack
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/50996/comment/f4d8017f_2370217b PS14, Line 222:
tab please ?
Done
https://review.coreboot.org/c/coreboot/+/50996/comment/c1602b86_98142131 PS14, Line 225: 16
sizeof(spd_array) ?
Done
https://review.coreboot.org/c/coreboot/+/50996/comment/1497437c_ddeedb62 PS14, Line 266:
tab please ?
Done
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/50996/comment/fe3acafd_95699359 PS17, Line 222: static
you don't need static here.
Done
https://review.coreboot.org/c/coreboot/+/50996/comment/544c65a1_7e358897 PS17, Line 271: mem_init_dq_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect); : mem_init_dqs_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect);
shouldn't this resides outside the loop ? we want to fill dq/dqs irrespective of you are passing the […]
Ack