19 May
2020
19 May
'20
2:05 a.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41095 )
Change subject: superio/winbond/w83977tf: Fix iasl warning ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41095/2/src/superio/winbond/w83977t... File src/superio/winbond/w83977tf/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/41095/2/src/superio/winbond/w83977t... PS2, Line 358: #ifdef SUPERIO_SHOW_UARTB
Maybe undefine it here instead?
I'd rather add another set of undefines after the include in line 361 to ensure that nobody else comes to depend on these symbols.
Oh, look! A wild commit appeared: CB:41530
--
To view, visit https://review.coreboot.org/c/coreboot/+/41095
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I031905479c66698fb01da028e3f37d923396d2d9
Gerrit-Change-Number: 41095
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 May 2020 08:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment