Sam Lewis has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44389 )
Change subject: Documentation: Add Beaglebone Black documentation ......................................................................
Patch Set 4:
(8 comments)
Thanks for reading it!
https://review.coreboot.org/c/coreboot/+/44389/3/Documentation/mainboard/ti/... File Documentation/mainboard/ti/beaglebone-black.md:
https://review.coreboot.org/c/coreboot/+/44389/3/Documentation/mainboard/ti/... PS3, Line 27: U-Boot "Falcon mode"
Do you have a link?
Have added one now.
https://review.coreboot.org/c/coreboot/+/44389/3/Documentation/mainboard/ti/... PS3, Line 33: boots, is effectively impossible to brick.
Please remove the trailing space.
Done
https://review.coreboot.org/c/coreboot/+/44389/3/Documentation/mainboard/ti/... PS3, Line 34:
Maybe also mention, that the BBB is often used as an external flasher and EHCI debug gadget.
Done
https://review.coreboot.org/c/coreboot/+/44389/3/Documentation/mainboard/ti/... PS3, Line 38: 2. Add a payload as normal.
I guess only depthcharge and Linux are supported? Maybe the documentation can be extended later.
depthcharge I'm not sure about as I don't think it has BBB support. Linux, yes. Normal ELF payloads are supported as well - in theory I think even U-Boot could be added as a coreboot payload.
https://review.coreboot.org/c/coreboot/+/44389/3/Documentation/mainboard/ti/... PS3, Line 99: ``` : &dcdc1_reg { : regulator-name = "vdd_ddr3"; : regulator-min-microvolt = <1350000>; : regulator-max-microvolt = <1350000>; : regulator-boot-on; : regulator-always-on; : }; : ```
If possible, I prefer indenting code blocks by four spaces, instead of using ```.
Done
https://review.coreboot.org/c/coreboot/+/44389/3/Documentation/mainboard/ti/... PS3, Line 119: mmc.c
Mark up as code?
Done
https://review.coreboot.org/c/coreboot/+/44389/3/Documentation/mainboard/ti/... PS3, Line 120: "FAT mode"
Emphasize using *…* instead of quotes?
Done
https://review.coreboot.org/c/coreboot/+/44389/3/Documentation/mainboard/ti/... PS3, Line 127: hang on a bad SD card or when the SD card is removed during boot.
Maybe create issues at https://ticket.coreboot. […]
Sure, will do once this gets merged in!