Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32118 )
Change subject: mb/google/sarien/variants/sarien: Update thermal configuration for DPTF
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32118/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32118/1//COMMIT_MSG@9
PS1, Line 9: Follow thermal table for second tunning.
Are these final tuning values based on latest system available ? OR will there be some more tuning coming in future ?
https://review.coreboot.org/#/c/32118/1/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/#/c/32118/1/src/mainboard/google/sarien/variants...
PS1, Line 45: 15
Any reason for this change ?
We had set 25W as per this BUG=b:122343940 mentioned in CL https://review.coreboot.org/c/coreboot/+/30908
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32118
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64844b84891dc3ab7abe9378cdca5dcf57b3e433
Gerrit-Change-Number: 32118
Gerrit-PatchSet: 1
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 29 Mar 2019 13:08:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment