Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46605 )
Change subject: lib/libpayload: Replace strapping_ids with new board configuration entry ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46605/9/payloads/libpayload/libc/co... File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/c/coreboot/+/46605/9/payloads/libpayload/libc/co... PS9, Line 283: info->sku_id = UNDEFINED_STRAPPING_ID; nit: Also initialize fw_config here, so things would be sane if we leave out the entry?
https://review.coreboot.org/c/coreboot/+/46605/9/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/46605/9/src/lib/coreboot_table.c@a2... PS9, Line 222: if (bid == UNDEFINED_STRAPPING_ID)
Right. […]
Libpayload actually initialized all lib_sysinfo strapping fields to UNDEFINED_STRAPPING_ID already in case the coreboot table entries were missing, see near the top of cb_parse_header(). Depthcharge depends on that.
The only thing you could decide here is whether you want to omit the coreboot table entry when all four strappings are UNDEFINED...