2 comments:
File payloads/libpayload/libc/coreboot.c:
Patch Set #9, Line 283: info->sku_id = UNDEFINED_STRAPPING_ID;
nit: Also initialize fw_config here, so things would be sane if we leave out the entry?
File src/lib/coreboot_table.c:
Patch Set #9, Line 222: if (bid == UNDEFINED_STRAPPING_ID)
Right. […]
Libpayload actually initialized all lib_sysinfo strapping fields to UNDEFINED_STRAPPING_ID already in case the coreboot table entries were missing, see near the top of cb_parse_header(). Depthcharge depends on that.
The only thing you could decide here is whether you want to omit the coreboot table entry when all four strappings are UNDEFINED...
To view, visit change 46605. To unsubscribe, or for help writing mail filters, visit settings.