Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: implement lpc config dump
......................................................................
Patch Set 2:
Isn't this just dumping the PCI config space? Or am I missing something here?
Putting register names on known PCI IDs doesn't sound like a bad idea though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bba1252635b3421051dd53f7d5adbd3d73ed1b6
Gerrit-Change-Number: 35189
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-Comment-Date: Sun, 01 Sep 2019 22:39:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment