Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42312 )
Change subject: tests: Fix a typo in tests/lib/Makefile.inc
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc
File tests/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42312/1/tests/lib/Makefile.inc@3
PS1, Line 3: # object files should be under build/tests/ build/test/src/ build/test/run/
Is this comment still accurate, anyway? As far as I know object files are under build/tests/<test-subdir>/<test-name>/ now. (I'm also not sure why we have a comment like this in the subdirectory Makefile.inc of some random test... if we want to explain how the test output directory is structured, that should probably go into the main tests/Makefile.inc instead.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42312
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I236b040a83700bcd34d99db61e5dad0ff7abb28c
Gerrit-Change-Number: 42312
Gerrit-PatchSet: 1
Gerrit-Owner: Anna Karaś
aka@semihalf.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Jun 2020 19:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
