Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40520 )
Change subject: drivers/smmstore: Implement SMMSTORE version 2 ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40520/12/Documentation/drivers/smms... File Documentation/drivers/smmstorev2.md:
https://review.coreboot.org/c/coreboot/+/40520/12/Documentation/drivers/smms... PS12, Line 116: INPUT: : - `com_buffer`: Physical address of the communication buffer (CBMEM) : - `com_buffer_size`: Size in bytes of the communication buffer I'm a bit confused by this. The coreboot table seems to provide the same thing but now you need to input this?
https://review.coreboot.org/c/coreboot/+/40520/12/src/drivers/smmstore/Kconf... File src/drivers/smmstore/Kconfig:
https://review.coreboot.org/c/coreboot/+/40520/12/src/drivers/smmstore/Kconf... PS12, Line 9: SMMSTOREV2 Maybe state that this disable v1 / that v2 and v1 are mutually exclusive? That should also be stated in the docs.
https://review.coreboot.org/c/coreboot/+/40520/12/src/drivers/smmstore/store... File src/drivers/smmstore/store.c:
https://review.coreboot.org/c/coreboot/+/40520/12/src/drivers/smmstore/store... PS12, Line 430: rdev_writeat I think the documentation should mention to clear a block before writing again at the same offset?