Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34882 )
Change subject: arch/x86: Move stack with CAR_GLOBAL_MIGRATION ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34882/1/src/include/stddef.h File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/34882/1/src/include/stddef.h@39 PS1, Line 39: #if defined(__PRE_RAM__) && CONFIG(ARCH_X86)
Why aren't we just modifying these conditions to handle the lzma case (large buffers in early stages […]
I did not realise it first, but I hit the AGESA -fno-zero-initialized-in-bss case with this approach. At the moment I don't know why even libagesa would need it.
https://review.coreboot.org/c/coreboot/+/34882/1/src/include/stddef.h@47 PS1, Line 47: #define DECLARE_MAYBE_STATIC_ZERO(x) x = 0
I'm not a big fan of initializing pointers to 0-value ints.
Neither am I. Some cases here would be zero, some NULL. Let's hope we don't need these at all.