Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42467 )
Change subject: drivers/intel/mipi_camera: SSDT changes to handle camera sensor
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came...
File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/42467/2/src/drivers/intel/mipi_came...
PS2, Line 25: FLASH_DISABLE = 2,
Does 1 not mean anything?
These's no definition for 1 in skycam's dsdt.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42467
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I581c9bf9b87eac69e88ec11724c3b26ee5fa9431
Gerrit-Change-Number: 42467
Gerrit-PatchSet: 2
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jun 2020 22:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment