Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )
Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset
......................................................................
Patch Set 7:
Patch Set 7:
Here is the patches I mentioned that define all the usb ports for each variant: https://review.coreboot.org/c/coreboot/+/46853
Thanks Duncan. I see you used aliases for usb ports and root hub. So if i make this depend on your CL this should be:
device ref south_xhci on
chip drivers/usb/acpi
device xhci_root_hub on
chip drivers/usb/acpi
register "desc" = ""Integrated CnVi bluetooth""
register "reset_gpio" = ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)"
device usb2_port10 on end
end
end
end
end
Shall i go ahead with the change above? please suggest.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46825
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieeb53d339cd2ee0be3b5c9d5cc517b4c7c9aa0b8
Gerrit-Change-Number: 46825
Gerrit-PatchSet: 7
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 27 Oct 2020 21:57:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment