Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42833 )
Change subject: soc/amd/picasso/soc_util: add function to detect defeatured SKU ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... PS1, Line 212: bool soc_is_defeatured_sku(void)
At least I do not understand, what *defeatured* means. Even after reading https://en.wiktionary. […]
Which features are missing? If it's just xhci1? We could change to something like soc_has_xhci1 and invert the logic?
https://review.coreboot.org/c/coreboot/+/42833/1/src/soc/amd/picasso/soc_uti... PS1, Line 214: SILICON_RV2 Could be reduced to 'soc_is_raven2() || soc_is_dali()'