build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45435 )
Change subject: nb/intel/gm45: Guard macro parameters ......................................................................
Patch Set 4:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... PS4, Line 234: #define MCHBAR8(x) *((volatile u8 *)(DEFAULT_MCHBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... PS4, Line 235: #define MCHBAR16(x) *((volatile u16 *)(DEFAULT_MCHBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... PS4, Line 236: #define MCHBAR32(x) *((volatile u32 *)(DEFAULT_MCHBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... PS4, Line 358: #define DMIBAR8(x) *((volatile u8 *)(DEFAULT_DMIBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... PS4, Line 359: #define DMIBAR16(x) *((volatile u16 *)(DEFAULT_DMIBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... PS4, Line 360: #define DMIBAR32(x) *((volatile u32 *)(DEFAULT_DMIBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... PS4, Line 375: #define EPBAR8(x) *((volatile u8 *)(DEFAULT_EPBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... PS4, Line 376: #define EPBAR16(x) *((volatile u16 *)(DEFAULT_EPBAR + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45435/4/src/northbridge/intel/gm45/... PS4, Line 377: #define EPBAR32(x) *((volatile u32 *)(DEFAULT_EPBAR + (x))) Macros with complex values should be enclosed in parentheses