6 Feb
2019
6 Feb
'19
5:32 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30419 )
Change subject: Makefile.inc: Optimize generating the default x86 fmap ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30419/4/util/cbfstool/default-x86.fmd File util/cbfstool/default-x86.fmd:
https://review.coreboot.org/#/c/30419/4/util/cbfstool/default-x86.fmd@14 PS4, Line 14: FMAP@##FMAP_BASE## ##FMAP_SIZE## The only concern I have is that I think some implementations do a binary search for the fmap, which will slow down with this layout. OTOH, I don't think any of these are in the critical path (eg. in coreboot), so...
--
To view, visit https://review.coreboot.org/c/coreboot/+/30419
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24fa6c89ecf85fb9002c0357f14aa970ee51b1df
Gerrit-Change-Number: 30419
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 06 Feb 2019 16:32:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment