Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37293 )
Change subject: mb/lenovo/t520/devicetree: Use subsystemid inheritance
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v...
File src/mainboard/lenovo/t520/variants/t520/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v...
PS1, Line 81: subsystemid 0x17aa 0x21ce
0x21cf?
According to this one it's actually 0x21ce (as some other Lenovo ThinkPad mainboards)
https://github.com/linuxhw/LsPCI/blob/master/Notebook/Lenovo/ThinkPad/ThinkP... T520 4242DV7/4425DA2AB25E/NEON-18.04/4.15.0-45-GENERIC/X86_64/7DF79D0141#L42
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92
Gerrit-Change-Number: 37293
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 30 Nov 2019 19:43:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment