Attention is currently required from: Felix Singer, Ahamed Husni, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67339 )
Change subject: drivers/smbus: smbus console driver ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67339/comment/b92b33fb_6ff22c73 PS1, Line 7: drivers/smbus: smbus console driver Please make that a statement by adding a verb in imperative mood [1].
[1]: https://cbea.ms/git-commit/
Patchset:
PS1: Nice work!
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/67339/comment/ec5d8b9e_51985c1f PS1, Line 305: Send coreboot debug output to the SMBus Please add a dot/period at the end.
https://review.coreboot.org/c/coreboot/+/67339/comment/db283ade_77b7717e PS1, Line 307: The output can be read with an I2C slave device connected the SMBus. Please refer to some documentation, or elaborate.