Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44569 )
Change subject: soc/mediatek/mt8192: Do dram fast calibration
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44569/5/src/soc/mediatek/mt8192/Kco...
File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/44569/5/src/soc/mediatek/mt8192/Kco...
PS5, Line 22: This option enables additional DRAM related debug messages.
We already have a debug RAM option in the *Debug* section in the top menu to my knowledge.
That should be DEBUG_RAM_SETUP and HAVE_DEBUG_RAM_SETUP?
But the MTK family has been using DEBUG_DRAM for a while (mt8173, mt8183, mt8192). I think the options can be changed together in a follow up patchset. Does that sound OK?
(@CK can you do that?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44569
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45a4fedc623aecfd000c5860e0e85175f45b8ded
Gerrit-Change-Number: 44569
Gerrit-PatchSet: 5
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Aug 2020 15:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment