Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37906 )
Change subject: mb/google/octopus: Add two new sku IDs for foob
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37906/1/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/foob/gpio.c:
https://review.coreboot.org/c/coreboot/+/37906/1/src/mainboard/google/octopu...
PS1, Line 42: sku1_override_table
non_touchscreen_override_table might be more meaningful?
https://review.coreboot.org/c/coreboot/+/37906/1/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/37906/1/src/mainboard/google/octopu...
PS1, Line 4: * Copyright 2018 Google LLC
2019?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffcbb3f6f945ea299ff687a383a82b88dcd11ea1
Gerrit-Change-Number: 37906
Gerrit-PatchSet: 1
Gerrit-Owner: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-Comment-Date: Tue, 24 Dec 2019 07:45:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment