Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43243 )
Change subject: mb/emulation/qemu-q35: Drop dead code ......................................................................
mb/emulation/qemu-q35: Drop dead code
This code is not even being build-tested. Drop it before it grows moss.
Change-Id: I54f3fe0d3b0c988ab6f9065bea81a385507e9747 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43243 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner --- M src/mainboard/emulation/qemu-q35/dsdt.asl 1 file changed, 0 insertions(+), 27 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/emulation/qemu-q35/dsdt.asl b/src/mainboard/emulation/qemu-q35/dsdt.asl index 1b4a174..a9c96be 100644 --- a/src/mainboard/emulation/qemu-q35/dsdt.asl +++ b/src/mainboard/emulation/qemu-q35/dsdt.asl @@ -58,24 +58,6 @@ // Never allow SHPC (no SHPC controller in this system) And(CTRL, 0x1D, CTRL)
-#if 0 // For now, nothing to do - If (Not(And(CDW1, 1))) { // Query flag clear? - // Disable GPEs for features granted native control. - If (And(CTRL, 0x01)) { // Hot plug control granted? - Store(0, HPCE) // clear the hot plug SCI enable bit - Store(1, HPCS) // clear the hot plug SCI status bit - } - If (And(CTRL, 0x04)) { // PME control granted? - Store(0, PMCE) // clear the PME SCI enable bit - Store(1, PMCS) // clear the PME SCI status bit - } - If (And(CTRL, 0x10)) { // OS restoring PCI Express cap structure? - // Set status to not restore PCI Express cap structure - // upon resume from S3 - Store(1, S3CR) - } - } -#endif If (LNotEqual(Arg1, One)) { // Unknown revision Or(CDW1, 0x08, CDW1) @@ -385,11 +367,6 @@ define_gsi_link(GSIH, 0, 0x17) }
-#if 0 -#include "../qemu-i440fx/acpi/cpu-hotplug.asl" -#endif - - /**************************************************************** * General purpose events ****************************************************************/ @@ -400,10 +377,6 @@ Method(_L00) { } Method(_L01) { -#if 0 - // CPU hotplug event - _SB.PRSC() -#endif } Method(_L02) { }