Attention is currently required from: Paul Menzel.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83879?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode ......................................................................
ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode
This patch adds support for the Intel Virtual Button driver, which reports whether a tablet is docked or undocked. The GPIO used for detection is hardcoded to GPP_F15 for now, specific to the `mb/starlite_adl` board.
The GPIO value is returned to the HID driver via the `_STA` and `VGBS` methods. These methods ensure proper notification to the OS, allowing it to show or hide the virtual keyboard depending on the docking status.
Tested on `starlite_adl` with Ubuntu 24.04, confirming the virtual keyboard appears when the tablet is undocked and hides when docked. This was verified with ACPI debug enabled, as dmesg does not report the state of the GPIO.
Change-Id: I574a1b2d3907b2341a0dfdc412151d574ba4848e Signed-off-by: Sean Rhodes sean@starlabs.systems --- A src/ec/starlabs/merlin/acpi/dock.asl M src/ec/starlabs/merlin/acpi/hid.asl 2 files changed, 56 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/83879/5