Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34138 )
Change subject: new file: toshiba/Kconfig new file: toshiba/Kconfig.name new file: toshiba/satellite_u940/Kconfig new file: toshiba/satellite_u940/Kconfig.name new file: toshiba/satellite_u940/Makefile.inc new file: toshiba/satellite_u940/acpi/ec.asl new file: toshiba/satellite_u940/acpi/platform.asl new file: toshiba/satellite_u940/acpi/superio.asl new file: toshiba/satellite_u940/acpi_tables.c new file: toshiba/satellite_u940/board_info.txt new file: toshiba/satellite_u940/devicetree.cb new file: toshiba/satellite_u940/dsdt.asl new file: toshiba/satellite_u940/gma-mainboard.ads new file: toshiba/satellite_u940/gpio.c new file: toshiba/satellite_u940/hda_verb.c new file: toshiba/satellite_u940/mainboard.c new file: toshiba/satellite_u940/romstage.c ......................................................................
Patch Set 1: Code-Review-2
It would be great if you'd address these issues.